Skip to content

"addban" CCMD regression fixes

A regression caused by 7e98b875463f made it impossible to use IP addresses with wild cards (e.g. 192.168.*.*) with the addban CCMD. Since NETADDRESS_s convertedAddress in SERVERBAN_BanAddress is only needed to get the index of a player with the given IP address, and IPList::addEntry already checks if the IP address is valid or not anyways, it's not too important to abort executing the CCMD if the IP address isn't formatted correctly.

I also needed to add an optional ignorePort parameter to SERVER_FindClientByAddress because the IP address string passed into SERVERBAN_BadAddress doesn't have a port number attached to it, so the former will always return -1 unless the port number is ignored during the check.

Merge request reports

Loading