Skip to content

Clientside demo fixes

Adam Kaminski requested to merge topic/default/clientside-demo-fixes into branch/default

I fixed a few bugs that I noticed that happen when watching clientside demos:

  1. A regression caused by e601fd00bcbe that would reset the name of the consoleplayer to "player" while watching a clientside demo.

  2. While in free spectate mode, the HUD (i.e. st_hud.cpp) is drawn as though the consoleplayer is the display player. However, when the HUD is refreshed, this isn't the case and the free spectator player is used instead. According to https://zandronum.com/tracker/view.php?id=4340, this can also cause the client to crash. For the sake of consistency, the display player should be used for refreshing and rendering the HUD (in this case, the consoleplayer).

  3. Although voice chat isn't used at all in demos, the "talking" status of the consoleplayer still updated during playback, even though it shouldn't.

Merge request reports