Skip to content

hg-core: separate timestamp and extra methods

Arun Kulshreshtha requested to merge topic/default/rust-split-timestamp-method into branch/default

Timestamp line parsing was recently implemented in !778 (merged). The API introduced in that implementation requires always parsing both the timestamp itself as well as the extras whenever either is desired.

Moreover, if either parsing step fails, the entire operation fails, so a corrupt extra would prevent access to the timestamp. (This wasn't an issue in the original implementation because corrupt extras were simply ignored, but we subsequently added validation before merging the previous MR.)

This MR proposes a better API with separate timestamp and extra methods on ChangelogRevisionData. The underlying logic remains the same; it's just exposed in a more user-friendly way.

Merge request reports