Skip to content

tests: don't rely on cloning into an empty directory

Dan Villiom Podlaski Christiansen requested to merge topic/default/unbreak-default into branch/default

Mercurial 5.8 and earlier would delete such a directory on errors, and the test accidentally relied on that behaviour. To work around that, we clone into the current directory, which Mercurial never deletes.

The test now reveals the incorrect behaviour, but the current design makes that difficult to address without tracking unnecessary state.

Addendum: We can fix this with the current design and organisation of the code, see 58831976d3b4, but it's a bit of a hack. I don't think it's worth it.

Closes !120 (closed)

Edited by Dan Villiom Podlaski Christiansen

Merge request reports