Skip to content

Unwanted decoration overlay on changesets in the Synchronize view

When running the 2.5.0 branch against an Oxygen.2 target platform, the changesets, whether uncommitted or outgoing, exhibit an unwelcome overlay in the bottom right corner as shown:

2018-02-19 20_01_15-runtime-TestMercurialEclipsemodifications-4.7.2 - HgTest_Issue545.txt.png

As can be seen in plugin.xml, we contribute such an overlay through the org.eclipse.ui.decorators extension point, either in ResourceDecorator or in FileStatusDecorator. However, I fail to see how our code is responsible for that overlay for the following reasons:

  • The overlay only shows up in Oxygen: running the same code with a Neon (4.6.x) target platform does not cause this unwanted overlay to show up,
  • The enablement in the extension point specifically requires the selection to be adaptable to IResource and obviously, we haven't provided an adapter factory, for instance for GroupedUncommittedChangeSet.

To reproduce it:

  • switch to the 2.5.0 branch,
  • configure a target platform to Oxygen 4.7.2 as shown below.

2018-02-19 20_12_22-Preferences.png

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information